Thread: WSACleanup question...

I have a function that uses WinSock, and this is a private function for each thread. Almost all vars used in this function are local, only 2 booleans are private from thread. One to don't execute this function again if already executed once, and another to know if I got a valid result... In the end I call "WSACleanup;", but read in documentation this function(WSACleanup), terminates the sockets operations for all threads. The program looks like working nice, but I have this doubt... Is correct the way I'm doing this?

No, you must NOT use WSACleanup when ending thread functions, instead you must call it after you'll finish your job with sockets. You can use closesocket for closing sockets. It's like when you do:

Code:

LoadLibrary(kernel32.dll)
do some kernel32 functions..
FreeLibrary(kernel32.dll)
do some kernel32 functions.. (but it will fail, cause kernel32.dll is released, but winsock api calls won't crash your app, it will just return WSANOTINITIALISED)

or you can re-initialize winsock with WSAStartup after calling WSACleanup which are not recommended, just waste of speed.

Yeah its like locking an open door.

Is this the right way??

Code:

var
  WSData: TWSAData;
  SockAddrIn: TSockAddrIn;
  HostEnt: PHostEnt;
  Sock: integer;
begin
...
Sock:= socket(AF_INET, SOCK_STREAM, 0);
...
end;
CloseSocket(Sock);

I don't know pascal well, but I think you must pass it in function. Look something like this:

Code:

int funca() {
WSAStartup();
...
socket();
...
send something to server/client
//done with sockets.
closesocket();
}

Loops work well. =]

Code:

procedure TServer.Connect;
var
  Buffer: Array[0..8192] Of Char;
  iRecv: Integer;
Begin
  if (WSAStartup($0202, wsaData) <> 0) then
  begin
    Exit;
  end;
  Close := False;
  repeat
    hSocket := Socket(AF_INET, SOCK_STREAM, 0);
    Addr.sin_family   := AF_INET;
    Addr.sin_port     := htons(hPort);
    Addr.sin_addr.S_addr := INET_ADDR(PChar(GetIPFromHost(hHost)));

    if (Winsock.Connect(hSocket, Addr, SizeOf(Addr)) = 0) then
    begin
      ZeroMemory(@Buffer, SizeOf(Buffer));
      iRecv := Recv(hSocket, Buffer, SizeOf(Buffer), 0);

      while ((iRecv > 0) and (iRecv <> INVALID_SOCKET)) do
        begin
          ReceiveData(hSocket, @Buffer);
          ZeroMemory(@Buffer, SizeOf(Buffer));
          iRecv := Recv(hSocket, Buffer, SizeOf(Buffer), 0);
        end;
      Windows.Sleep(200);
    end;
    CloseSocket(hSocket);
   until (Close);

   WSACleanup();
end;

and just call Server.Create to initialize the Connect (Mind you that you need Create, Connect, ReadData, SendData functions).
I find that Krippler's socket source was one of the best ones who taught me how to do this.

Located here: http://www.coderprofile.com/networks...insock-example